Skip to main content

Siteglide CLI - Pull should pull all public module files

Status: Completed4 comments

Log in to comment and vote

Comments4

  • Matt Jones

    •

    Aug 17

    •

    Merged request

    •

    4 votes

    Siteglide CLI - Treatment of Assets Folder in Pull v.s. Deploy

    Clarify if Siteglide-CLI command deploy includes CSS and JS files when -w flag is not used.

    Expected behaviour: Deploy and Pull default without flags should behave the same way when it comes to the assets folder.

    Actual behaviour: Pull command treats assets like CSS and JS specially and pulls them even if no flags are added. Larger images like images are not pulled without a flag and I think export command.

    Deploy requires a flag before deploying these same CSS and JS asset types?

    If this change is not desirable or possible, let's update the docs to make this clear. Otherwise there can be confusion/ ambiguity when using deploy on live sites where Liquid is pushed without necessary changes to JS.

    • Matt Jones

      Team•

      Aug 6

      To clarify, the task description correctly describes the current behaviour.

      Deploy does not include CSS and JS unless you use the -w flag. Pull does include the CSS and JS.

      To those who voted on this, would you have any recommendations for behaviour? Should deploy include by default the same set of assets (mostly JS and CSS) as pull?

      @Rox Dawson @Vaibhav Karande @Sunil